Skip to content

Remove local miner dash #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove local miner dash #532

wants to merge 1 commit into from

Conversation

@sli-tao
Copy link
Contributor

@sli-tao sli-tao commented Apr 16, 2025 •
edited
Loading

Taoshi Pull Request

Description

To be merged in the future when the local dash diverges from main dash. For now, we can leave these features in.

Removes all local miner dash files
Preserves the raw data endpoint

Related Issues (JIRA)

[Reference any related issues or tasks that this pull request addresses or closes.]

Checklist

  • I have tested my changes on testnet.
  • I have updated any necessary documentation.
  • I have added unit tests for my changes (if applicable).
  • If there are breaking changes for validators, I have (or will) notify the community in Discord of the release.

Reviewer Instructions

[Provide any specific instructions or areas you would like the reviewer to focus on.]

Definition of Done

  • Code has been reviewed.
  • All checks and tests pass.
  • Documentation is up to date.
  • Approved by at least one reviewer.

Checklist (for the reviewer)

  • Code follows project conventions.
  • Code is well-documented.
  • Changes are necessary and align with the project's goals.
  • No breaking changes introduced.

Optional: Deploy Notes

[Any instructions or notes related to deployment, if applicable.]

/cc @mention_reviewer

@deepsource-io
Copy link

deepsource-io bot commented Apr 16, 2025 •
edited
Loading

Here's the code health analysis summary for commits 1832ade..60480bf. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython❌ Failure
❗ 4 occurences introduced
🎯 10 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage79.6%79.6%
Line Coverage79.6%79.6%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@sli-tao sli-tao changed the title Deprecate local miner dash Remove local miner dash Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trdougherty trdougherty Awaiting requested review from trdougherty trdougherty is a code owner

@taoshidev1 taoshidev1 Awaiting requested review from taoshidev1 taoshidev1 is a code owner

@derekawender derekawender Awaiting requested review from derekawender derekawender is a code owner

@jbonilla-tao jbonilla-tao Awaiting requested review from jbonilla-tao jbonilla-tao is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sli-tao